-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reuses MarkerClusterGroup #647
Conversation
MarkerClusterGroup seems to extend LayerGroup so should be fine using backend-determined clusters while this plugin handles stacked pins
Hey @derekmiranda, thanks for the help! I don't think this is necessarily a regression, since I wasn't thinking of the stacked pins problem when I took out the MarkerClusterGroup originally. If it solves that problem, them I'm all for it. However, I did notice a different bug that we had before with the MarkerClusterGroup. When you're zoomed all the way in and click on a cluster with stacked pins, they do the spiderify thing. And then if you click on one of the pins, the popup appears for a moment and then disappears. If you click on the cluster again, and then click on the same pin again, it stays open. I'm not sure if there's a way to fix that. Maybe it should be a new ticket. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! Agree with what Jake said - no issues with reusing MarkerClusterGroup if it accomplishes what we need. Unfortunately, it did reintroduce the bug in #461 . I reopened the bug ticket in case you wanted to take a look at it.
Even with the autoclustering after clicking a pin, this is better than stacked pins. Going to merge this and we can tackle the clustering in another PR. |
Hey guys, thanks for reviewing! I'll take a look at the reopened issue |
MarkerClusterGroup seems to extend LayerGroup so should be fine using
backend-determined clusters while this plugin handles stacked pins. Not sure if this is a regression since @jmensch1 had changed it from MarkerClusterGroup to LayerGroup.
Also, pins at same lat/lng don't seem to automatically spiderfy even though
spiderfyOnMaxZoom
is enabled by default. Users will have to click on a fully zoomed-in stacked cluster to spread them.Fixes #{issue number here}
dev
branchAny questions? See the getting started guide