Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Front ie11 support #768

Merged
merged 11 commits into from
Aug 5, 2020
Merged

Front ie11 support #768

merged 11 commits into from
Aug 5, 2020

Conversation

adamkendis
Copy link
Member

@adamkendis adamkendis commented Aug 5, 2020

Fixes #756
Fixes #765

Eslint error workaround

Eslint started throwing a strange error a few days ago.

TypeError: Cannot read property 'range' of null
Occurred while linting /home/runner/work/311-data/311-data/src/components/Comparison/TotalRequestsComparison.jsx:26

See https://github.com/hackforla/311-data/pull/763/checks?check_run_id=934365378

I found several issues re the same eslint error. See this issue. I used a workaround in the comments thread by adding/disabling two rules. This is a temporary solution.

IE11 support

It turned out that the most recent version of dfa node_module, a dependency of @react-pdf/fontkit is not transpiled from ES6 to ES5. Explicitly including these files for babel-loader while excluding everything else in node_modules didn't work - ended up being some issues with the transpiled code for @react-pdf with this method. npm installing the prior version of dfa ended up fixing the issue. There is a pending PR to fix this on dfa here. See issue on @react-pdf here

query-string latest version is also not IE11 compatible so this was reverted from 6 to 5. From the query-string readme:

This module targets Node.js 6 or later and the latest version of Chrome, Firefox, and Safari.
If you want support for older browsers, or, if your project is using create-react-app v1, use version 5: npm install query-string@5.

Also added the core-js/stable import to the frontend entrypoint for polyfills and updated @babel/preset-env config.

Other stuff

Updated footer links and added social media icons to footers. Moved version and privacy policy to left side of footers.

Screen Shot 2020-08-04 at 10 34 25 PM

  • Up to date with dev branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Any questions? See the getting started guide

@adamkendis adamkendis requested a review from jmensch1 August 5, 2020 05:43
@adamkendis adamkendis merged commit dabf385 into hackforla:dev Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant