-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new unit tests with new library versions + fixes #792
Conversation
Well, now flake8 is working and tests are running... But asserts are all getting errors because of data differences. Somehow the numbers don't add up between my local and the dev site. I think it's possible that the data is the same, but the clusters are different. I'm seeing both total 690K from Jan 1 to June 30 but the sites have different cluster grouping. Not sure why this could be the case. Might need to change the asserts if we can't figure out a better plan. |
thanks for the feedback @jmensch1 ! Any other pressing tests for me to add? |
I don't have any tests to add for now. Great start, we can get this merged and add more tests later. |
Current db seeding from file is loading 100K records and taking 33s to load to the DB on CI. Might want a larger seed file. Everything is passing except for 2 postman tests (though i had to disable 1 pytest where the data is not matching). |
…a/311-data into 789-begin-test-refactor
…a/311-data into 789-begin-test-refactor
First set of work on #789
Before doing more refactoring wanted to have some better test coverage of the API services methods which is where the heart of the logic resides.
Key bugs that library upgrades introduced were:
Currently, the new functions are included as services functions. They are needed to help develop test but I put them there since I can see a future where we want to expose these as API endpoints.
I have a 'do not merge' label on this for now as the scope of the changes is beyond what I had initially intended. Unfortunately and especially since async support is pretty new in Python, I think we need to keep libraries relatively up to date. I don't know what the specific problem was but I couldn't get my tests to work until I updated everything.
I'd also like to discuss running Python 3.8.
And lastly, would like to know if there are other critical pieces of functionality that need tests before this can merge.
dev
branch