562 front accessibility panel #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
adamkendis
suggested changes
Sep 17, 2020
There was a problem hiding this comment.
The info panel looks awesome. The only problem I'm seeing is that the icon and the entire panel aren't accessible via tab. This functionality is critical for keyboard users. The icon should be tabbed to after "Contact Us" and the user should be able to tab through the info panel.
Will probably also need the aria-expanded attribute on the icon to indicate whether the panel is collapsed or expanded.
Good work!
Fix faulty merge conflict resolution in Header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #{562}
devbranchAny questions? See the getting started guide