Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

582 keyboard accessibility #814

Merged
merged 11 commits into from
Oct 31, 2020
Merged

582 keyboard accessibility #814

merged 11 commits into from
Oct 31, 2020

Conversation

alexchoiweb
Copy link
Member

@alexchoiweb alexchoiweb commented Sep 24, 2020 •
edited by adamkendis
Loading

Fixes #582

  • Up to date with dev branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Any questions? See the getting started guide

adamkendis
adamkendis approved these changes Oct 31, 2020
View reviewed changes
Copy link
Member

@adamkendis adamkendis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I just changed the skip links to double-arrow icons instead of text.

@adamkendis adamkendis merged commit 762dc47 into dev Oct 31, 2020
@adamkendis adamkendis deleted the 582-keyboard-accessibility-alex branch October 31, 2020 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamkendis adamkendis adamkendis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Keyboard accessibility - global ticket
2 participants
@alexchoiweb @adamkendis