809 screenreader support #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 8, 2020 02:11
…b accessibility to charts
…ut seems to be correct after pressing submit
ghost
requested a review
from 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #809
devbranchMap Container:
Note--Some elements of aria-label are updating before submit button pressed because I'm using componentDidUpdate within pinmap component. Seems to be up to date on submit button being pressed through my manual testing.
Time-to-Close Chart:
Frequency / Total Request Charts:
Note -- Was not able to add individual aria-label to each data point because this chart is made through canvas and data points do not have individual HTML elements. Couldn't find library/solution that added accessibility through chart.js
311 Contact Pie Chart: