836 map setting menu left drawer #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f0d3fcf.
adamkendis
reviewed
Dec 18, 2020
| display: 'flex', | ||
| }, | ||
| appBar: { | ||
| transition: theme.transitions.create(['margin', 'width'], { |
There was a problem hiding this comment.
awesome, haven't used this before
There was a problem hiding this comment.
Actually, I dont think this is being used anywhere! Got it from the material component.
Will remove.
adamkendis
reviewed
Dec 18, 2020
| }; | ||
|
|
||
| const escFunction = e => { | ||
| e.preventDefault(); |
There was a problem hiding this comment.
it looks like this is preventing the chrome devtools keyboard shortcut from working. a couple options that fixed it, hopefully without causing any side effects:
- move e.preventDefault inside the
ifblock - change the eventListener to 'keypress' instead of 'keydown'
keypress fires after keydown, so maybe that's somehow messing up the shortcut?
adamkendis
suggested changes
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #836
devbranchAny questions? See the getting started guide
Note: The web drawer looks different than the one pictured. I based it off the mobile screen