Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor LandingPageIntro #498

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Conversation

bzzz-coding
Copy link
Member

@bzzz-coding bzzz-coding commented Feb 5, 2024

Fixes #496

Changes

  • Restyled LandingPageIntro with TailwindCSS
  • Deleted Sass for LandingPageIntro
  • Replaced <a> with <Link> from react-router-dom; added <MemoryRouter> for testing <Link>

Screenshots, if applicable

Mobile

Desktop

Copy link
Member

@bennyv8 bennyv8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled and ran tests. No issues found with the refactor from scss styling to tailwind.

Also, from my understanding memory router was added to the test scripts because the landing page was utilizing link components. Should that mean we also add memory router at the top level of all our routes? Additionally, should we also refactor all anchor tags pointing to a different browser URL to utilize link components instead?

@bzzz-coding
Copy link
Member Author

Thanks for reviewing my PR, @bennyv8 !

I added so Jest can test the page that now uses instead of . I suppose we need to do this when testing any page that uses routing context. Maybe there is an easier way.

I prefer to anchor tags for UX and preserving state, but maybe instead of refactoring all anchor tags at once, we can replace them with as we encounter them?

@bzzz-coding bzzz-coding merged commit fd766f0 into hackforla:main Feb 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Landing Page
2 participants