-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: script to clean up backend emails #1612
base: development
Are you sure you want to change the base?
feat: script to clean up backend emails #1612
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
@spiteless review the PR it only works on the |
4efedbd
to
9c349e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nayan, we have one thing to consider. the User object is linked to checkin objects. and we want to make sure that if we delete a user than the userId in the checkin object is replaced also.. does that make sense? feel free to slack me if you want me to explain further
Can you give me some hints?? Or point me to some resource... I don't fully understand it!! |
I am so sorry for the crappy review above. the fear is that we may have an orphaned record, or zombie data. definition of orphaned data"Orphaned data refers to data that is no longer associated with a corresponding record or entity in a database, data storage or other information system. This situation typically arises when a record, file, or object is deleted, but the associated data remains in the system without a proper link to a parent entity. " The checkin data references the users. and maybe we want to consolidate those checkins the same way you consolidated the rest of the data. We will bring this up in the meeting today and give you a better review. Again, apologies about the review above |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you create a test-data.json file with dummy data in it?
@jbubar I've added the test-data.json file as required. Review the changes when you are free |
@jbubar Can you please review this PR when you have a chance? |
@jbubar Just checking in on this PR - do you think you will have a chance to review soon? If not, we can request a review from @trilliumsmith |
#1551
What changes did you make and why did you make them ?
test-data.json
also the script is saved in.mjs
format to run it on nodetest-data.json
was the file I didn't included in the PR it consists of all the users information and can be created by making a GET request tohttp://localhost:4000/api/users/
with ThunderClient, then copying the contents to the a new file in the newly createdscripts
folderIdentified Uppercase emails
Uppercase emails