-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update HTML to MUI in VRMS/client/src/components/admin/reports /index.js #1706
base: development
Are you sure you want to change the base?
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Hey @nora-zajzon, I see that you've taken on multiple tickets as we've gone throught he month of July:
Thanks for taking these on! It looks like each subsequent PR you're making is including the changes from work on the previous issue (this PR contains changes to 4 files). At the moment it is fine, but please do take care to revert to the Planning on reviewing them in the order that they were submitted :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @nora-zajzon, can you double check your commits locally? I don't see any file changes to client/src/components/admin/reports/index.js
in this PR
@trillium Do you still want me to submit a pr for index even though it is not in the current iteration of the app? I do have it locally so I can |
No, if you'd prefer to pass on it you're welcome to. If you'd like to see it through we'll review and accept it :) |
Fixes #1679
What changes did you make and why did you make them ?
Visuals after changes are applied