-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serious Bug: Map - Mobile map doesn’t update when viewing an organization #2028
Comments
Hi @hanapotski , just checked out the devla site today and there's something weird happening: When I tap on an org pin, the pin smooth-scrolls off the screen! Very smooth, but kinda weird :) Screen.Recording.2024-04-03.at.3.13.18.PM.mov |
Thanks 🙏 This is a known bug. Qiqi's looking into it 👌 |
Still working on this, but adding notes here for future me and future team:
|
I believe issue is at L119 of ![]() ![]() In In const onClick = (e) => {
mapRef.current?.flyTo({
center: [
isListPanelOpen && !isMobile ? e.lngLat.lng - 0.08 : e.lngLat.lng,
isMobile ? e.lngLat.lat - 0.03 : e.lngLat.lat,
],
duration: 2000,
});
// . . .
}; Two potential solutions:
|
The same issue appears on mobile - and it’s trickier since the map viewport can change when the text panel resizes: the above issue is very serious as it makes the mobile site very unusable |
closing this as this was fixed in this PR |
Hi folks -- thanks for tackling this! I just QAed at devla.foodoasis.net -- could you check on these two issues? (I'm reopening this so it grabs your attention but let me know if there's something else we should do for QA stuff)
Screen.Recording.2024-08-05.at.7.22.20.PM.720p.mov |
Not sure if it's a normal behavior for a user to resize the window 🤔 |
It doesn’t require resizing - that’s just to show the issues at different sizes, and the working one at desktop size. Try it out with browsers at those sizes - iPad portrait and a smartphone |
Hi Guys. I checked the devla.foodoasis.net site : this is what I am experiencing still: The icons are nonresponsive at times. And they are still NOT CENTERED in the selected location in the mobile version. Please see the clip attached: FOLA-BUG_.PIN.issue.mp4 |
This issue seems like a subset of Please look at both — it’s likely the solution fixes both bugs. This is high priority because the site is very unusable and buggy when the map goes off in unexpected directions! Hot-fix asap, please! |
Hi 👋 we are aware of the unresponsive icons bug, we have a ticket for it. Someone's already taking a look at it 👍 |
just saw this. I think we should add a separate ticket for this as this needs more research/experimenting |
Describe the bug
Serious bug:
When viewing a list of organizations, and tapping one to get details about it, the map does not update show or highlight the organization’s pin. Often the pin is way off-screen.
The map should re-center (ideally with a smooth scroll/pan) on the highlighted pin automatically, ideally showing both the user’s current location and the pin so that they can determine the relative location.
Steps to reproduce the issue
(if applicable, please specify platform (iOS, Android, Windows, Mac version) and brower)
What's the expected result?
Map should re-center on the organization’s pin automatically, each time a new organization is viewed.
Ideally, the map smoothly pans to the new location, and ideally, the user’s current location / entered address is also visible on the map (though this may be difficult if the user has panned the map manually)
See Apple or Google maps or Yelp on mobile phones for example.
What's the actual result?
The organization’s pin may be highlighted, but is often off-screen with no indication for how to find the pin itself.
This is a regression — the previous version centered on highlighted pins properly.
Additional details / screenshot
A similar problem appears when searching from the map screen.
From landing page, enter an address. On desktop, map Pin appears in the wrong place but map pans correct place at first.
![IMG_1253](https://private-user-images.githubusercontent.com/3376957/350647829-cf8cc736-3d32-4d47-b1df-c11b90211b6e.jpeg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQzMjcxNzcsIm5iZiI6MTcyNDMyNjg3NywicGF0aCI6Ii8zMzc2OTU3LzM1MDY0NzgyOS1jZjhjYzczNi0zZDMyLTRkNDctYjFkZi1jMTFiOTAyMTFiNmUuanBlZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODIyVDExNDExN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWI3OGZlZTA0NWE1MDM1MjY5MTRmMzhkYTIxYTc2OGM1YjY4OTFjMmJiMTYzNDM2ZjMwYWVmOTJlM2NiOTg5MzQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.BcOcUdzsD9_0wmR3jU6bD2HcfI5TUX8k-RgRQ08nBGM)
Do a search again from the map page and the map now re-centers in the wrong place, and the pin doesn’t move to the correct place.
![IMG_1252](https://private-user-images.githubusercontent.com/3376957/350647840-8f2c2963-54e4-4f92-8cde-400a22217782.jpeg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQzMjcxNzcsIm5iZiI6MTcyNDMyNjg3NywicGF0aCI6Ii8zMzc2OTU3LzM1MDY0Nzg0MC04ZjJjMjk2My01NGU0LTRmOTItOGNkZS00MDBhMjIyMTc3ODIuanBlZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODIyVDExNDExN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTZmNTAyYTg1YzIxODQzZmMwMzIyZmQ1YTcwNmViYjk0Y2YzNjI2MzhlODRhN2FhMjBlNmQ2YjJkYmRjZjQ0MzImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.izI19_sn0TbvJyXX7hrq4aKbXmUcC46M39yU9o0KlFQ)
ScreenRecording_07-19-2024.17-15-01_1.mp4
To it might have something to do with loading the page for the first time vs going to a new location
Device configuration
Related issues
The text was updated successfully, but these errors were encountered: