Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update react-map-gl to v7 #2030

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Update react-map-gl to v7 #2030

merged 1 commit into from
Mar 5, 2024

Conversation

hanapotski
Copy link
Contributor

@hanapotski hanapotski commented Mar 4, 2024 •
edited
Loading

Fixes #2029

@andyarensman
Copy link
Member

I think the issue with #2028 is that the highlighted pin can't be seen when the drawer is out. So maybe the drawer could close partially when the user clicks a location? Not sure.

Screenshot_20240304-101523_Chrome

Screenshot_20240304-101530_Chrome

@hanapotski
Copy link
Contributor Author

will do it in another PR 👌

junjun107
junjun107 approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@junjun107 junjun107 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hanapotski hanapotski merged commit 482db37 into develop Mar 5, 2024
@hanapotski hanapotski deleted the 2029-update-mapbox-version branch March 5, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junjun107 junjun107 junjun107 approved these changes

@andyarensman andyarensman andyarensman approved these changes

@93Belen 93Belen 93Belen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
P: FOLA: Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Serious Bug: Map zoom controls are too sensitive
4 participants
@hanapotski @andyarensman @junjun107 @93Belen