-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Many contact fields are invalid - they should be URLs but are usernames, and don’t work on the website #2128
Comments
Adding helpful comments from slack for future reference: Saumil Bryan Wu 3 files Bryan Wu Note how this Facebook url has “pages” in it before the username/handle |
Notes from a meeting between John D and me today:
|
Adding my notes for some ideas on tooltips for LinkedIn and Twitter: For LinkedIn (Source: https://www.linkedin.com/help/linkedin/answer/a542685/manage-your-public-profile-url?lang=en#:~:text=You%20can%20create%20your%20public,profile%20URL%20at%20a%20time.)
For X (Source: https://help.x.com/en/managing-your-account/x-username-rules)
@fancyham Hi Bryan, the above examples do not cover all the scenarios but we can leave a note saying if the URL doesn't match the above format reach out to your admin or something else. Please share your thoughts on if the above examples could be used for tooltips or if we can add/change some more info. I will add similar info for pinterest, facebook, instagram next as well. Thanks. |
Thanks for doing that research! So… I still think it’d be far simpler to just use the full URL, perhaps in all cases? Could you help me understand why we’d not want to do that? Is it difficult for the user in some cases? A database thing? Etc? |
Thanks for doing that research, BTW |
Thanks Bryan. We discussed this during our dev meeting yesterday and using the full URL would be simpler. So, we have decided to go ahead with that. I would add more notes in this issue with examples for tooltips for each of the social media we use. Also, planning to break this issue down into smaller issues for each social media contact field. Hope it works. Thank you. |
Describe the bug
Maybe not really a bug but an issue with our data and form fields that allow invalid info.
Many of our listings have incorrect URLs for Instagram, Twitter, etc. because volunteers are entering @username in the fields rather than the properly formatted full URLs that our system is expecting
Noting this as an issue so we don’t forget it and because devs may be able to help find and fix errors, or solve a different way.
What we need to do
We need to clean these up, and prevent it from happening in the future.
Possible solutions
Some possible solutions:
We could allow usernames and URLs both, and the website parses the field and displays the full URL appropriately
We could make all fields usernames-only and run a script to replace URLs with usernames in database, then display the full URL on the website
We should also display errors when field is incorrectly formatted to help data validators enter fields correctly
and (optionally) prevent approval (and display error message) if these aren’t valid URLs
How to recreate
For example, go to this organization (unless it’s been fixed since this bug report):
https://foodoasis.la/organizations?latitude=34.081648&longitude=-117.740882&org=god%27s_pantry_-_pomona&id=4772
In the database:
<img width="838" alt="image" src="https://github.com/hackforla/food-oasis/assets/3376957/45ded83d-f8aa-490b-af7d-8555a6c5bd10”>
Our web site - Instagram icon has malformed URL (it should be going to Instagram.com/godspantry_org)
Video: https://github.com/hackforla/food-oasis/assets/3376957/f7a8a5c2-9397-4b8a-8f1e-a186fdf0de58
The text was updated successfully, but these errors were encountered: