Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added tooltips for social media URLS #2169

Conversation

SAUMILDHANKAR
Copy link
Member

@SAUMILDHANKAR SAUMILDHANKAR commented Jul 12, 2024

old

original.mp4

new

tooltip.design.mp4

@fancyham
Copy link
Collaborator

fancyham commented Jul 16, 2024

Hi there, nice progress — for each of the tooltips, please also give an example URL as appropriate for each service, i.e. https://instagram.com/…, https:://faceboook.com/…

So: Instagram tooltip would be “This org’s full URL: https://instagram.com/…”

Also, please error-check that the field is an actual URL and display as an error when the field is populated, but not a proper web URL

@fancyham fancyham self-requested a review July 16, 2024 21:13
modified tooltips and added validation
@SAUMILDHANKAR SAUMILDHANKAR force-pushed the saumildhankar-2128-fixing-contact-fields-to-be-urls branch from 6e0832c to 578dfbb Compare July 21, 2024 17:56
@SAUMILDHANKAR
Copy link
Member Author

Following video demonstrates the updated tooltip text and the error message that would be generated if the URL isn't valid. I have used a simple regular expression for validation but we can explore more options if required.

updated.tooltip.and.validation.mp4

@SAUMILDHANKAR SAUMILDHANKAR marked this pull request as ready for review July 21, 2024 18:04
Copy link
Collaborator

@fancyham fancyham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Looking at the tooltip text, let’s adjust it smidge to read:

”This org’s full Instagram URL (e.g. https://instagram.com/…)” — so adding the parenthesis and e.g.

Also, just want to make sure that both http:// and https:// works validates as URLs for the error checking? If so, then that’s great.

Love it.

Is there a place I can try this out myself — perhaps on the dev site?

@SAUMILDHANKAR
Copy link
Member Author

SAUMILDHANKAR commented Jul 23, 2024

Hi Bryan, based on today's dev standup meeting, need your feedback on a few points regarding this PR. I have left a detailed summary message on slack. Looking forward to your response. Thank you.

Link to the comment with follow up discussion - #2128 (comment)

@SAUMILDHANKAR
Copy link
Member Author

Closing this PR since this is being worked on other smaller issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants