Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the PDF Print format so the footer appears on each page #1791

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

bilalbg
Copy link
Contributor

@bilalbg bilalbg commented Aug 19, 2024

Fixes #1757

What changes did you make?

  • Made it so the PDF print footer appears at the bottom of every page without overlapping
  • Justify content to bottom for when the footer is smaller (i.e. no snapshots)

Why did you make the changes (we will use this info to test)?

  • Footer appears right under the body instead of at the bottom of every page

Issue-Specific User Account

If you registered a new, temporary TDM User Account for this issue, indicate the
username (i.e., email address) for the account.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

old_pdf_1

old_pdf_2

old_pdf_3_small_footer

Visuals after changes are applied

new_pdf_1

new_pdf_2

new_pdf_3_small_footer

Copy link
Member

@entrotech entrotech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@entrotech entrotech merged commit 9a83b1b into develop Aug 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify the PDF Print format so the footer appears on each page.
2 participants