Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused alt-hero field from public-tree-map.md project file #3209

Closed
1 of 4 tasks
Tracked by #2722
JessicaLucindaCheng opened this issue Jun 3, 2022 · 7 comments · Fixed by #3751
Closed
1 of 4 tasks
Tracked by #2722

Remove unused alt-hero field from public-tree-map.md project file #3209

JessicaLucindaCheng opened this issue Jun 3, 2022 · 7 comments · Fixed by #3751
Assignees
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less Status: Updated No blockers and update is ready for review

Comments

@JessicaLucindaCheng
Copy link
Member

JessicaLucindaCheng commented Jun 3, 2022

Overview

As a developer, I want to make sure unused code is removed from the codebase in project cards so that

  • time to load the website is as low as possible,
  • it's easier to understand the code, and
  • time to review the code is reduced.

Details

In project md files, image-hero is a decorative background image and alt-hero is the alt text associated with image-hero. However, alt-hero text is not used anywhere in our codebase since the image-hero is used as an SCSS background image.

Moreover, if the image-hero were to be used in an img HTML tag in the future, the alt text for all the image-hero images would be alt="", which could be set programmatically for all the alt properties associated with each image-hero.

Action Items

  • For the file _projects/public-tree-map.md, remove line 8 for the alt-hero
alt-hero: 'Coral tree from City of Santa Monica. Photo by Dave Baiocchi www.studiobaiocchi.net'

Resources/Instructions

File and code links you will need to work on this issue

  • Directory to find the page once you have it in your IDE: _projects/public-tree-map.md
  • Click on the link below to see the source file code:
    alt-hero: 'Coral tree from City of Santa Monica. Photo by Dave Baiocchi www.studiobaiocchi.net'

Information about WCAG

@JessicaLucindaCheng JessicaLucindaCheng added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) Size: Good second issue size: 0.5pt Can be done in 3 hours or less labels Jun 3, 2022
@github-actions

This comment was marked as resolved.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as resolved.

@github-actions

This comment was marked as resolved.

@h3nry-m
Copy link
Member

h3nry-m commented Nov 28, 2022

Progress: "What is the current status of your project? What have you completed and what is left to do?"
Currently complete!
Blockers: "Difficulties or errors encountered."
No blockers.
Availability: "How much time will you have this week to work on this issue?"
This weekend.
ETA: "When do you expect this issue to be completed?"
Just completed.

@h3nry-m h3nry-m added Status: Updated No blockers and update is ready for review and removed 2 weeks inactive labels Nov 28, 2022
@ExperimentsInHonesty
Copy link
Member

I didn't realize this alt text was a photo credit. This PR will need to be reverted, and the credit information added to the Credits page

@ExperimentsInHonesty ExperimentsInHonesty added the ready for dev lead Issues that tech leads or merge team members need to follow up on label Jan 15, 2023
@jdingeman
Copy link
Member

jdingeman commented Feb 2, 2023

I didn't realize this alt text was a photo credit. This PR will need to be reverted, and the credit information added to the Credits page

@jdingeman jdingeman added Ready for Prioritization and removed ready for dev lead Issues that tech leads or merge team members need to follow up on labels Feb 2, 2023
@ExperimentsInHonesty ExperimentsInHonesty added the good first issue Good for newcomers label Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less Status: Updated No blockers and update is ready for review
Projects
Development

Successfully merging a pull request may close this issue.

4 participants