Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unused alt-hero field #3751

Merged
merged 1 commit into from
Nov 29, 2022
Merged

Removed unused alt-hero field #3751

merged 1 commit into from
Nov 29, 2022

Conversation

h3nry-m
Copy link
Member

@h3nry-m h3nry-m commented Nov 28, 2022

Fixes #3209

What changes did you make and why did you make them ?

  • Removed the unused alt-hero field because it was not being used anywhere in the code page since the image-hero was being used as a background image.
  • As a result it'll reduce unnecessary code as well as reduce time to review code and load the website.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b h3nry-m-remove-unused-alt-hero gh-pages
git pull https://github.com/h3nry-m/website.git remove-unused-alt-hero

@github-actions github-actions bot added 2 weeks inactive P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less labels Nov 28, 2022
@Suman2795 Suman2795 self-requested a review November 28, 2022 17:20
Suman2795
Suman2795 approved these changes Nov 28, 2022
View reviewed changes
Copy link
Member

@Suman2795 Suman2795 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job @h3nry-m ! Your pull request is done into the correct branch and you have linked it to the correct issue. Your changes look correct which removes the unnecessary code.

@jdingeman jdingeman merged commit 0aab399 into hackforla:gh-pages Nov 29, 2022
esantiano pushed a commit to esantiano/website that referenced this pull request Dec 4, 2022
@h3nry-m @esantiano
Removed unused alt-hero field (hackforla#3751)
dd1427f
@jdingeman jdingeman mentioned this pull request Feb 2, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Suman2795 Suman2795 Suman2795 approved these changes

Assignees
No one assigned
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove unused alt-hero field from public-tree-map.md project file
4 participants
@h3nry-m @Suman2795 @ExperimentsInHonesty @jdingeman