-
-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Unique iDs for each wins entry #2635
Add Unique iDs for each wins entry #2635
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Once this PR gets approved, the actual App Script is going to be modified :) |
@lopezpedres Hi Miguel, thanks for working on the issue and adding the video. It looks good. Is line 44 the only change that you made in the App script? Let me know when you are available to go over the changes. We can test if all the sections are still working fine. I don't think we need to merge this. Once done we can just close the issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please share the code changes that you made in your App Scrip.
Hi @SAUMILDHANKAR, yes It's only one line! It was a pretty easy issue. The hard part was to get familiar with App Script and to find the reason why my code wasn't working. We can go over the changes this Tuesday if you are free, maybe in-office hours? |
@lopezpedres Thanks Miguel. Lets go over it during the office hours. I wanted to discuss the case where if one of the rows' display value is changed to false, the unique IDs will change. If we can use timestamp as the unique ID instead, this could be resolved since they are more unique. |
@SAUMILDHANKAR That sounds like a good idea! I can start working on it 👍 |
Review ETA: 2/15/22 |
I am closing this PR as there is no need to merge _wins-data.json file. For this issue, data should get merged through the bot account. The code changes suggested by Miguel are in a comment in the issue. Also, adding ignore label as there is no need of QA on this and all the information is available in the linked issue. Thanks Miguel for working on this. Great job! |
Fixes #2385
What changes did you make and why did you make them?
Video of applied changes
The main goal of the video is to show how the unique IDs are added to the wins object
trial__wins-data.json.at.main.lopezpedres_trial.-.Google.Chrome.2021-12-27.11-55-55.mp4