Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unused alt-hero #3213 #3745

Merged
merged 1 commit into from
Nov 25, 2022
Merged

Removed unused alt-hero #3213 #3745

merged 1 commit into from
Nov 25, 2022

Conversation

Satenik-Ba
Copy link
Member

Fixes #3213

What changes did you make and why did you make them ?

  • Removed unused alt-hero field from undebate.md project file
    (alt-hero: "Silhouette of three people sitting in chairs. Two of them have empty speach bubbles over their heads.")
  • alt-hero text is not used anywhere in the codebase since the image-hero is used as an SCSS background image.
  • No visuals before changes are applied

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b Satenik-Ba-remove-unused-alt-hero-3213 gh-pages
git pull https://github.com/Satenik-Ba/website.git remove-unused-alt-hero-3213

@github-actions github-actions bot added P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less Size: Good second issue labels Nov 25, 2022
@t-will-gillis t-will-gillis self-requested a review November 25, 2022 19:05
@t-will-gillis
Copy link
Member

Availability: Friday 11/25 11-2
review ETA: Friday 11/25

t-will-gillis
t-will-gillis approved these changes Nov 25, 2022
View reviewed changes
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Satenik-Ba -You make the correct edits to the correct file- i.e. deleting Line 8 from undebate.md, used the right branch, and made no unintended changes to the website. Great job!

MattPereira
MattPereira approved these changes Nov 25, 2022
View reviewed changes
Copy link
Contributor

@MattPereira MattPereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @Satenik-Ba ! 👍

You completed the action items from the issue and did a great job summarizing your changes for this pull request.

@MattPereira MattPereira merged commit f99cbe5 into hackforla:gh-pages Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-will-gillis t-will-gillis t-will-gillis approved these changes

@MattPereira MattPereira MattPereira approved these changes

Assignees
No one assigned
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove unused alt-hero field from undebate.md project file
4 participants
@Satenik-Ba @t-will-gillis @MattPereira @ExperimentsInHonesty