-
-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added image-hero-credit field and create public-tree-map.yml file #4278
added image-hero-credit field and create public-tree-map.yml file #4278
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Review ETA: By end of day tomorrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this issue @ftblmagician, it appears that the issue this pull request is for wasn't successfully linked. Looks like it's just missing the # sign in front of the number is all.
Review ETA: In the next few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ftblmagician Once the issue is correctly linked, I will go ahead and approve the changes. I do not see any other problems with this PR.
|
Okay... I believe I made the change now |
The issue still doesn't appear to be linked for me. I think you should be able to edit your original comment from when you first made this pull request by clicking the three dots at the top right of that specific comment. The first line "Fixes 3922" just needs to be changed to "Fixes #3922" I believe. |
@ftblmagician I see that the issue is still persisting. You will need to hyperlink the issue to the issue number. Once it has been hyperlinked, I will be able to approve of the commit. |
ok now I think I got it! thank you for the help! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it is fixed! Nice job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting the issue linked. All the requests from the issue have been done and it looks like the changes show up on the credits page like they're supposed to, so this should be good to merge. Good job on completing the issue.
Fixes #3922
What changes did you make and why did you make them ?
A new image-hero-credit field was added to the public-tree-map.md file. The field was added in order to give the photographer credit for the image.
A public-tree-map.yml file was created and added into data/internal/credits. The file adds the image to the credits page which gives credit to the photographer.