Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added image-hero-credit field and create public-tree-map.yml file #4278

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

ftblmagician
Copy link
Member

@ftblmagician ftblmagician commented Mar 24, 2023

Fixes #3922

What changes did you make and why did you make them ?

  • A new image-hero-credit field was added to the public-tree-map.md file. The field was added in order to give the photographer credit for the image.

  • A public-tree-map.yml file was created and added into data/internal/credits. The file adds the image to the credits page which gives credit to the photographer.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b ftblmagician-update-image-hero-3922 gh-pages
git pull https://github.com/ftblmagician/website.git update-image-hero-3922

@bootcamp-brian
Copy link
Member

Review ETA: By end of day tomorrow
Availability: Weekdays this week before 5pm

Copy link
Member

@bootcamp-brian bootcamp-brian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this issue @ftblmagician, it appears that the issue this pull request is for wasn't successfully linked. Looks like it's just missing the # sign in front of the number is all.

@KazushiR
Copy link
Member

Review ETA: In the next few minutes.
Availability: Weekdays

Copy link
Member

@KazushiR KazushiR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ftblmagician Once the issue is correctly linked, I will go ahead and approve the changes. I do not see any other problems with this PR.

@ftblmagician
Copy link
Member Author

ftblmagician commented Mar 28, 2023

Fixes #3922

What changes did you make and why did you make them ?

  • A new image-hero-credit field was added to the public-tree-map.md file. The field was added in order to give the photographer credit for the image.
  • A public-tree-map.yml file was created and added into data/internal/credits. The file adds the image to the credits page which gives credit to the photographer.

@ftblmagician
Copy link
Member Author

Okay... I believe I made the change now

@bootcamp-brian
Copy link
Member

Okay... I believe I made the change now

The issue still doesn't appear to be linked for me. I think you should be able to edit your original comment from when you first made this pull request by clicking the three dots at the top right of that specific comment. The first line "Fixes 3922" just needs to be changed to "Fixes #3922" I believe.

@KazushiR
Copy link
Member

@ftblmagician I see that the issue is still persisting. You will need to hyperlink the issue to the issue number. Once it has been hyperlinked, I will be able to approve of the commit.

@ftblmagician
Copy link
Member Author

ok now I think I got it! thank you for the help!

@ftblmagician ftblmagician requested a review from KazushiR March 29, 2023 04:07
@github-actions github-actions bot added role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe P-Feature: Credit https://www.hackforla.org/credits/ Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 1pt Can be done in 4-6 hours labels Mar 29, 2023
Copy link
Member

@KazushiR KazushiR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it is fixed! Nice job!

Copy link
Member

@bootcamp-brian bootcamp-brian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting the issue linked. All the requests from the issue have been done and it looks like the changes show up on the credits page like they're supposed to, so this should be good to merge. Good job on completing the issue.

@jdingeman jdingeman merged commit 6325bfc into hackforla:gh-pages Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Credit https://www.hackforla.org/credits/ P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours time sensitive Needs to be worked on by a particular timeframe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add image-hero-credit to public-tree-map.md and create a new credit
4 participants