BUG or Issue....

[geogerar]

Hello,

First of all I would like to thank you for such a brilliant and nice tool!!
Now, I want to inform you that, in IOS7 but also in IOS6 with ScrollView containing a textview it doesn't work well. The keyboard when comes up scrolls the navigation bar out of view with textview.
I can see only the half bottom part of textview.....
Can you please check and correct?

Thank you very much in advance!

George Gerardis

[hackiftekhar]

Will try to solve this very soon. Can you you provide 2-3 screenshots, which demonstrates this issue?

Thanks
Iftekhar

[geogerar]

Thank you for your answer.....
I am sending you 4 screenshoots waiting for your reply...

Thanks again

George Gerardis

On Sun, Dec 29, 2013 at 9:22 PM, Mohd Iftekhar Qurashi <
notifications@github.com> wrote:

Will try to solve this very soon. Can you you provide 2-3 screenshots,
which demonstrates this issue?

Thanks
Iftekhar

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/15#issuecomment-31323212
.

Γιώργος Ν. Γεράρδης

[hackiftekhar]

Hi Geogerar,
I didn't receive screenshots which you share. Please let me know how can I get that?

[geogerar]

Hello,

sorry my friend but I was send them 2 days ago at the following
email... hackiftekhar/IQKeyboardManager

I am sending them again at the prsent email of yourself.....

Thank you again!!!

On Mon, Dec 30, 2013 at 7:30 PM, Mohd Iftekhar Qurashi <
notifications@github.com> wrote:

Hi Geogerar,
I didn't receive screenshots which you share. Please let me know how can I
get that?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/15#issuecomment-31357105
.

Γιώργος Ν. Γεράρδης

[hackiftekhar]

Please send to hack.iftekhar@gmail.com

[geogerar]

I am sending again just now ....

Thanks

[hackiftekhar]

I understand the issue you are facing. I came up with 2 solutions for this:-

1. Change and maintain frame of UITextView on this condition.
2. Not to scroll if textView goes outside of UIViewController's View.

Please suggest me the best solutions. If you have another idea on this, I would love to hear from you.

Best
Iftekhar

[geogerar]

Hello again,

First of all I would like to wosh you a huppy nove healthy NEW year.

Now, I think that solution No:1 is better .

If you have time please correct that issue, I am waiting.....

Thnk you very much in advance!

George Gerardis

On Tue, Dec 31, 2013 at 8:00 AM, Mohd Iftekhar Qurashi <
notifications@github.com> wrote:

I understand the issue you are facing. I came up with 2 solutions for
this:-

1. Change and maintain frame of UITextView on this condition.
2. Not to scroll if textView goes outside of UIViewController's View.

Please suggest me the best solutions. If you have another idea on this, I
would love to hear from you.

Best
Iftekhar

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/15#issuecomment-31385068
.

Γιώργος Ν. Γεράρδης

[hackiftekhar]

But I think if we change UITextView frame inside my code then it may break user's logic. What do you think?

[geogerar]

maybe yes....but the strange thing is that I do change nothing in my app.
I just use a textView ( DALinedTextView ----> This is a class textview with
lines and you can find in GITHUB ) and nothing else.
When I use IQKEYBOARDMANAGER the view goes out of screen with navigation
bar BUT normally only the textview must scroll without to
move navigation bar.....
This is the problem as you can see in screen shoots.

I can not understand where the problem is....

George Gerardis

On Tue, Dec 31, 2013 at 5:34 PM, Mohd Iftekhar Qurashi <
notifications@github.com> wrote:

But I think if we change UITextView frame inside my code then it may break
user's logic. What do you think?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/15#issuecomment-31398683
.

Γιώργος Ν. Γεράρδης

[hackiftekhar]

One temporary solution is to disable it on ViewWillAppear [[IQKeyboardManager sharedManager] setEnabled:NO]; and reEnable it on ViewWillDisappear.

[geogerar]

Hello again,

The temporary solution you propose does not work simply because by doing
that is like to have not implement at all IQKEYBOARDMANAGER in my app.
no scrolling, keyboard covers the textview etc etc...

I think we have to find out a better solution....

Thanks again for helping me.....

George

On Tue, Dec 31, 2013 at 9:09 PM, Mohd Iftekhar Qurashi <
notifications@github.com> wrote:

One temporary solution is to disable it on ViewWillAppear
[[IQKeyboardManager sharedManager] setEnabled:NO]; and reEnable it on
ViewWillDisappear.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/15#issuecomment-31407147
.

Γιώργος Ν. Γεράρδης

[hackiftekhar]

I am suggesting this solution is only for your particular ViewController. Desable it on ViewWillAppear and Enable it on ViewWillDisappear. I am not suggesting you to set it to on your whole app.

By the way, I implemented both solutions for this. I added a boolean called 'canAdjustTextView' If it is YES then Implementation goes to 1st solution, otherwise 2nd. I have fixed some more issues also. read my commit message for details.

Many many thanks for the bug report to improve this control. Wishing a happy new year to you also.

Thanks
Iftekhar

[geogerar]

You solve my problem!!!
Very nice solution.....excellent!!
Thank you very very much for your help!!!

George

[geogerar]

You solve my problem!!!
Very nice solution.....excellent!!
Thank you very very much for your help!!!

George

On Wed, Jan 1, 2014 at 4:23 PM, Mohd Iftekhar Qurashi <
notifications@github.com> wrote:

Closed #15 #15.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/15
.

Γιώργος Ν. Γεράρδης

[geogerar]

Hello again,
I am sending you some screen shoots to identify a small problem!
Now, the most works fine......initial screen textview fine, keyboard not
covered text....
But a small problem with navigation bar which now is partial moved!!!

Thanks again for your help

George

On Wed, Jan 1, 2014 at 11:23 PM, George Gerardis geogerar@gmail.com wrote:

You solve my problem!!!
Very nice solution.....excellent!!
Thank you very very much for your help!!!

George

On Wed, Jan 1, 2014 at 4:23 PM, Mohd Iftekhar Qurashi <
notifications@github.com> wrote:

Closed #15 #15.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/15
.

Γιώργος Ν. Γεράρδης

Γιώργος Ν. Γεράρδης

[hackiftekhar]

Hello geogerar,
Actually this is not a problem, this is the functionality I implemented. The textView will move upside till the iPhone screen ends( I left 30px from the top). then if necessary I adjust the frame of textView.

Thanks
Iftekhar

[geogerar]

Hello,

I see, ok fine!

Thanks a lot again!

George

On Thu, Jan 2, 2014 at 7:47 PM, Mohd Iftekhar Qurashi <
notifications@github.com> wrote:

Hello geogerar,
Actually this is not a problem, this is the functionality I implemented.
The textView will move upside till the iPhone screen ends( I left 30px from
the top). then if necessary I adjust the frame of textView.

Thanks
Iftekhar

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/15#issuecomment-31469816
.

Γιώργος Ν. Γεράρδης