Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Q-Chem 6 + Misc Updates #770

Merged
merged 43 commits into from
Mar 14, 2023
Merged

Q-Chem 6 + Misc Updates #770

merged 43 commits into from
Mar 14, 2023

Conversation

samblau
Copy link
Contributor

@samblau samblau commented Feb 28, 2023

Summary

  • A variety of additions and modifications for Q-Chem 6, including supporting new Q-Chem features and updating Pymatgen and Custodian functionality and default values.
  • Parsing raw gradient and Hessian files. Hessians are particularly important, because they are not printed in the output file, and saving them allows us to then print them out and use them as inputs to a subsequent optimization calculation.
  • Some minor additions related to dipoles and HOMO/LUMO gap info.

@samblau
Copy link
Contributor Author

samblau commented Feb 28, 2023

@Zhuoying, what's up with all the failing VASP tests? I haven't changed any VASP code. Might be due to switching to a newer pymatgen version? Your help would be appreciated.

@samblau
Copy link
Contributor Author

samblau commented Mar 11, 2023

@naik-aakash Seems like lobster tests are failing here too

@JaGeo
Copy link
Contributor

JaGeo commented Mar 12, 2023

Some keys in the lobsterout class changed. We will fix it. Shouldn't take too long.

@naik-aakash
Copy link

@naik-aakash Seems like lobster tests are failing here too

@samblau , I will fix it tomorrow morning. Thanks for notifying. :-)

@naik-aakash
Copy link

naik-aakash commented Mar 13, 2023

#771 Hi @samblau , This PR should fix failing lobster tests with updated pymatgen.

@Zhuoying
Copy link
Contributor

Hi @samblau , thanks for the PR. I just merged the PR by @naik-aakash on lobster test fix.
You could git pull first. I saw a failure in atomate/qchem/tests/test_drones.py may need a fix before passing the tests. If all tests pass, I will merge this PR. Thanks!

@samblau
Copy link
Contributor Author

samblau commented Mar 13, 2023

@Zhuoying We're good to go

@samblau samblau changed the title Q-Chem 6 + Misc Updates [WIP] Q-Chem 6 + Misc Updates Mar 13, 2023
@Zhuoying Zhuoying merged commit a041423 into hackingmaterials:main Mar 14, 2023
@Zhuoying
Copy link
Contributor

@samblau Great! Thanks for the excellent contribution. I just merged it~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants