Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autofeaturizer caching needs to use matminer utils, not pd.json #226

Closed
ardunn opened this issue Sep 17, 2019 · 0 comments · Fixed by #246
Closed

Autofeaturizer caching needs to use matminer utils, not pd.json #226

ardunn opened this issue Sep 17, 2019 · 0 comments · Fixed by #246
Labels
bug bug

Comments

@ardunn
Copy link
Contributor

ardunn commented Sep 17, 2019

Should be consistent whether or not you are storing pymatgen object, and pandas will fail if using pymatgen objects to static files. needs matminer.utils.io.store/read_dataframe_from json functions used instead
@ardunn ardunn added the easy label Oct 4, 2019
ardunn added a commit to ardunn/automatminer that referenced this issue Oct 12, 2019
@ardunn
fix hackingmaterials#226
84adc9f
@ardunn ardunn removed the easy label Oct 12, 2019
@ardunn ardunn mentioned this issue Oct 12, 2019
Merged
@ardunn ardunn added the bug bug label Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

serialize backend and test improvements ardunn/automatminer
1 participant
@ardunn