Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MatPipe.load should refuse to load from class instance #234

Closed
ardunn opened this issue Oct 4, 2019 · 0 comments · Fixed by #246
Closed

MatPipe.load should refuse to load from class instance #234

ardunn opened this issue Oct 4, 2019 · 0 comments · Fixed by #246
Labels
bug bug

Comments

@ardunn
Copy link
Contributor

ardunn commented Oct 4, 2019

MatPipe load should not work if the pipe was previously defined in an instance. It should only work as a static/classmethod usage, not as an instance usage. This is because it is more reliable to load and define matpipes entirely at one time rather than mixing and matching constituent classes through __init__ and __load__

Good:

MatPipe.load(file)

Bad:

pipe = MatPipe(**some_config)
pipe.load(file)
@ardunn ardunn added the easy label Oct 4, 2019
ardunn added a commit to ardunn/automatminer that referenced this issue Oct 12, 2019
@ardunn ardunn added bug bug and removed easy labels Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant