Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pipeline logger #119

Merged
merged 6 commits into from
Nov 5, 2018
Merged

Fix pipeline logger #119

merged 6 commits into from
Nov 5, 2018

Conversation

utf
Copy link
Member

@utf utf commented Nov 2, 2018

Fix for the master Pipeline logger not working.

Not really sure about tests for the logger? Seems very hard/impossible to test a mixin class without also testing some other class?

@ardunn
Copy link
Contributor

ardunn commented Nov 2, 2018

ah ok if is too much of a pain don’t worry about it. i already test (super) basic logging in the utils

to test though u could make a class in the test file and pass the mixin to inherit though, right?

@utf utf merged commit 49ed271 into hackingmaterials:master Nov 5, 2018
@utf utf mentioned this pull request Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants