-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make metaselection part of AutoFeaturizer #120
Conversation
_add_composition..
Hey Qi, I have a few questions
|
Thanks for the comments, Alex!@ardunn
|
yes tests work for me right now with OFM enabled... |
re: datasets, ok i think now it is merged though |
@Qi-max sorry the refactor is causing some conflicts here. You can probably just pull most recent changes and update and everything will be ok I'll go ahead and merge once the following items are taken care of:
|
I think the PR is good now. @ardunn |
Great, thanks for doing this @Qi-max |
define
_customize_featurizers
to customizeself.featurizers
and add metaselection to be part of it. Users can useself.metaselector
to get theFeaturizerMetaSelector
class, containingself.metaselector.dataset_mfs
(dataset_metafeatures calculated for this dataset),self.metaselector.excludes
(auto excluded featurizers that do not work) etc.make
self.featurizers
only contain featurizers for featurizer_types that have corresponding column in the dataframe, or say the featurizers that we are really going to use. User-specificed featurizers does not have this restriction._add_composition_from_structure
is called before _customize_featurizers to use metaselection for the added composition columnrename the default column name to be "composition" instead of the original "formula"
make
dataset_metafeatures
,composition_statistics
etc as def instead of classfix some minor issues of the original glass_binary.csv and update the tests related to it
add tests for the metaselection part in
TestAutoFeaturizer
, fix copy.copy and add docs etc