Refactor mslearn to use matminer for its dataset needs #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 7, 2018 14:50
example scripts out of main mslearn code base
added 3 commits
November 13, 2018 15:35
…earn into dataset_update # Conflicts: # mslearn/data/load.py # mslearn/data/sources/glass_binary.csv # mslearn/featurization/metaselection/tests/test_core.py # mslearn/featurization/metaselection/tests/test_metafeatures.py
…earn into dataset_update # Conflicts: # mslearn/data/load.py # mslearn/data/sources/glass_binary.csv # mslearn/featurization/metaselection/tests/test_core.py # mslearn/featurization/metaselection/tests/test_metafeatures.py
|
Going ahead and merging as I see no reason people would be against it |
|
awesome thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the code in mslearn to use matminer to handle datasets rather than using its own dedicated loaders and such. @ardunn I also refactored the examples and benchmarking code out of the mslearn directory to have some separation of scripts and actual package code. Letting you know about this before merging to make sure that's fine.
EDIT: After finding an issue with the way matminer 0.4.4 is installed which breaks the dataset loaders this should not be merged until matminer is updated to fix this.
EDIT 2: Issue has been fixed, ready to merge.