Analytics Module Tests #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ardunn
reviewed
Jan 14, 2019
automatminer/automl/adaptors.py
Outdated
| @@ -118,9 +118,9 @@ def fit(self, df, target, **fit_kwargs): | |||
| self._features = df.drop(columns=target).columns.tolist() | |||
There was a problem hiding this comment.
Again, not sure why this adaptor stuff is being changed....
There was a problem hiding this comment.
You're right, the logger attribute should not be changed. I thought the presence of the underscore was the reason I was getting issues in the other parts of that file, but it must have been something else. I'll change it back
|
Looks good, thank you! Could you resolve the logger comments I posted? I'll merge after that! |
|
@ardunn This one should also be good to go |
|
@ADA110 you have conflicting files (see above). Please resolve and I'll go ahead and merge |
|
@ardunn merge conflict resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for the analytics class, including feature importance and partial dependence plots. Testing includes checking the presence of a list of features and verifying that certain partial dependence plots are saved in the same folder based on this specific example.