Merge pull request #905 from hackingmaterials/ml-evs/fix-mp-test

Skip the thermo tests rather than crash if MP API is missing
hackingmaterials · May 30, 2023 · 29f13fd · 29f13fd
2 parents e8c54ee + 607210a
commit 29f13fd
Showing 1 changed file with 11 additions and 2 deletions.
diff --git a/matminer/featurizers/composition/tests/test_thermo.py b/matminer/featurizers/composition/tests/test_thermo.py
@@ -9,14 +9,23 @@
 
 class ThermoFeaturesTest(CompositionFeaturesTest):
     def test_cohesive_energy(self):
-        mpr = MPRester()
+        try:
+            mpr = MPRester()
+        except ValueError:
+            raise SkipTest("Materials Project API key not set; Skipping cohesive energy test")
+
         if not mpr.api_key:
             raise SkipTest("Materials Project API key not set; Skipping cohesive energy test")
+
         df_cohesive_energy = CohesiveEnergy().featurize_dataframe(self.df, col_id="composition")
         self.assertAlmostEqual(df_cohesive_energy["cohesive energy"][0], 5.179358342, 2)
 
     def test_cohesive_energy_mp(self):
-        mpr = MPRester()
+        try:
+            mpr = MPRester()
+        except ValueError:
+            raise SkipTest("Materials Project API key not set; Skipping cohesive energy test")
+
         if not mpr.api_key:
             raise SkipTest("Materials Project API key not set; Skipping cohesive energy test")
         ce = CohesiveEnergyMP()