Reintroduce pandas pin and update code for numpy 1.24+ #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ml-evs
force-pushed
the
ml-evs/deps-tinkering
branch
from
f46b707
to
71381d5
Compare
ml-evs
changed the title
|
Related to #915. |
ml-evs
force-pushed
the
ml-evs/deps-tinkering
branch
from
1d54b9d
to
d4ca969
Compare
ml-evs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This "hypothetical" PR (pending discussion in #915) reintroduces the pandas pin, and re-enables the previously broken tests so that we can safely release the patches for the new pymatgen (that affects lots of users). It also bumps the minimum supported Numpy version following the recommendations of SPEC 0000.
Closes #916.
Closes #923.