Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing impute_nan for WenAlloys and removed unnecessary warning #937

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

gbrunin
Copy link
Contributor

@gbrunin gbrunin commented Apr 22, 2024

Summary

This fixes 2 small things:

  • A warning about NaN imputation was written in case ElementProperty was initialiazed with impute_nan=False, even though the data source could be itself initialized with impute_nan=True. The warning is removed, since the imputation is only happening at the level of the data source.
  • I missed an imputation in WenAlloys featurizer.

I'm make some tests now to decide whether the default of impute_nan should be switched to True.

Copy link
Collaborator

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ml-evs ml-evs changed the title Previous PR followup: missed an imputation, removed unnecessary warning. Added missing impute_nan for WenAlloys and removed unnecessary warning Apr 22, 2024
@ml-evs ml-evs merged commit 19798db into hackingmaterials:main Apr 22, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants