Skip to content
This repository has been archived by the owner on Jul 6, 2019. It is now read-only.

A hack to make the code compile again #43

Merged
merged 2 commits into from
May 31, 2014

Conversation

farcaller
Copy link
Member

Rustc forcefully exports stack_exhausted and eh_personality, resulting
in symbols being defined twice. We counter this by stripping the
symbols from all object files being produced.

Rustc forcefully exports stack_exhausted and eh_personality, resulting
in symbols being defined twice. We counter this by stripping the
symbols from all object files being produced.
@farcaller farcaller closed this May 30, 2014
@farcaller farcaller deleted the fix-missing-lang-items branch May 30, 2014 16:19
@bharrisau
Copy link
Contributor

You could try the following linker flag?

--allow-multiple-definition
-z muldefs
Normally when a symbol is defined multiple times, the linker will report a fatal error. These options allow multiple definitions and the first definition will be used

@farcaller farcaller restored the fix-missing-lang-items branch May 31, 2014 08:25
@farcaller farcaller reopened this May 31, 2014
@farcaller
Copy link
Member Author

--allow-multiple-definition

This one is a bit too permissive.

farcaller added a commit that referenced this pull request May 31, 2014
A hack to make the code compile again
@farcaller farcaller merged commit 0d67094 into hackndev:master May 31, 2014
@bharrisau
Copy link
Contributor

Probably safer sticking with the strip pass than telling the linker that multiple-defs are ok. This is the first run of the stats submission, so have to see how it works.

@farcaller farcaller deleted the fix-missing-lang-items branch June 1, 2014 08:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants