HCK-7928: ScyllaDB deactivated view fields are not commented out in FE #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Nightlngale
commented
Sep 10, 2024
•
Nightlngale
commented
 HCK-7928 ScyllaDB deactivated view fields are not commented out in FE
|
taras-dubyk
requested changes
Sep 10, 2024
| const firstActiveIndex = columnsDefinitions.findIndex(item => item.isActivated); | ||
|
|
||
| return columnsDefinitions.map(({ name, isActivated }, index) => { | ||
| const statement = `${index === 0 || firstActiveIndex === index ? '' : ','} ${name}`; |
There was a problem hiding this comment.
I didn't get it. If I have a deactivated column myColumn will it look like this: /*, myColumn*/ ?
There was a problem hiding this comment.
Yes. The idea was to have a valid syntax once it's uncommented. Also, I used /* */ instead of -- because this plugin does not have a formating
taras-dubyk
approved these changes
Sep 11, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.