-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HCK-7928: ScyllaDB deactivated view fields are not commented out in FE #67
Conversation
Nightlngale
commented
Sep 10, 2024
•
edited by github-actions
bot
Loading
edited by github-actions
bot
HCK-7928 ScyllaDB deactivated view fields are not commented out in FE |
const firstActiveIndex = columnsDefinitions.findIndex(item => item.isActivated); | ||
|
||
return columnsDefinitions.map(({ name, isActivated }, index) => { | ||
const statement = `${index === 0 || firstActiveIndex === index ? '' : ','} ${name}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't get it. If I have a deactivated column myColumn
will it look like this: /*, myColumn*/
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. The idea was to have a valid syntax once it's uncommented. Also, I used /* */ instead of -- because this plugin does not have a formating
Quality Gate passedIssues Measures |