VitePress migration #2479
Merged
VitePress migration #2479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lifehackerhansol
force-pushed
the
vitepress
branch
25 times, most recently
from
de31b4d
to
c01f4b7
Compare
lifehackerhansol
force-pushed
the
vitepress
branch
2 times, most recently
from
377bb43
to
5ae50a6
Compare
4 tasks
- Add theme submodule - Add initial configuration files - Override theme-default VPHero/VPFooter with custom theme version - Update README
lifehackerhansol
force-pushed
the
vitepress
branch
2 times, most recently
from
b15964f
to
988d7f3
Compare
Things that happen in this shameless squash:
- Removed 404 page
- It doesn't work in VitePress and making it work in VitePress needs
some invasive hack in the theme that I'm not willing to do
- The default is more than enough, though
- Moved consoleVersionSelect include to another directory
- This avoids being uploaded to Crowdin for translation
- Inline all SafeB9SInstaller includes
- Not only do parameterized includes not work, but if/else statements
don't work at all
- The sysupdate include parameter hasn't been used since MSET9, so it
actually works just fine without any parameters. Hooray(?)
- Move mset9-chorus to an include, that logic doesn't work in VitePress
- Removed Get Started button from homepage, it breaks translations
- Tables in get-started are now shown by default; it seems VitePress really does
not want us to use inline script. So we cannot enable it upon
realizing that the browser is JS capable
- Include parameters are now in frontmatter to allow translation
- Hacked in a bunch of CSS values kanged from the old theme to make it
look not stupid
- Drop headers down one level to make table of contents work
The image is taken from [0], and processed with ImageMagick: `convert chromeos.png -trim -resize 600x` This fixes the issue of the logo being invisible in light mode. [0]: https://partnermarketinghub.withgoogle.com/brands/chromebook/chromebook/visual-identity/visual-identity/logos-and-badges/
All previous copyrights held in this repository were related to the old theme which is no longer in use.
They don't work the way our guide does. Our guide, for a lack of a better word, interleaves between paths, so the next button is almost always incorrect. We have always added a button to the correct next page manually anyway, so just rely on that.
This allows to show more than just h2, which is needed for the section numbers that currently use h3.
These should not be in the final build. It also breaks build with dead link checks enabled, which is default.
These need to be regenerated by Crowdin.
To allow these to be linked to.
Jekyll is no longer used.
lifehackerhansol
force-pushed
the
vitepress
branch
from
988d7f3
to
bc555ec
Compare
lifehackerhansol
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to the age and the infeasibility to update the out-of-tree fork of minimal mistakes, I propose we migrate to VitePress.
No features of the guide are lost as of the migration.
Note that all translations will need to be disabled upon migration as the current markdown will not work as is and Crowdin will need to regenerate them.
Progress: