Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flags for projects #157

Merged
merged 6 commits into from
Oct 22, 2024
Merged

flags for projects #157

merged 6 commits into from
Oct 22, 2024

Conversation

veermshah
Copy link
Contributor

… to open up a popup with more details.

Description

Added flag icons to projects that have been flagged. You can click on the flag to pop open the Flags Popup and see more details about the flag. Also added a button to filter out "busy" flags.

Fixes #[Issue]

Type of Change

Delete options that do not apply:

  • New feature (non-breaking change which adds functionality)

Is this a breaking change?

  • Yes
  • [ X] No

Copy link

vercel bot commented Oct 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jury ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 4:43pm

@veermshah veermshah changed the title added Flags to projects tab of admin panel. You can click on the flag… flags for projects Oct 20, 2024
Copy link
Contributor

@MichaelZhao21 MichaelZhao21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty good but look at the stylistic changes I proposed

client/src/components/admin/FlagsPopup.tsx Show resolved Hide resolved
client/src/components/admin/FlagsPopup.tsx Outdated Show resolved Hide resolved
client/src/components/admin/FlagsPopup.tsx Outdated Show resolved Hide resolved
client/src/components/admin/FlagsPopup.tsx Outdated Show resolved Hide resolved
client/src/components/admin/tables/ProjectRow.tsx Outdated Show resolved Hide resolved
client/src/components/admin/tables/ProjectRow.tsx Outdated Show resolved Hide resolved
client/src/components/admin/tables/ProjectRow.tsx Outdated Show resolved Hide resolved
client/src/components/admin/tables/ProjectRow.tsx Outdated Show resolved Hide resolved
client/src/components/admin/tables/ProjectsTable.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@MichaelZhao21 MichaelZhao21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Erm for some reason when I click on the first table's flags (Table 1 Arke), it shows all the flags...

image

I also have one small style thing. Also can you just remove the ability to see busy flags at all (filter them out permanently) and remove the checkbox

client/src/components/admin/FlagsPopup.tsx Outdated Show resolved Hide resolved
client/src/components/admin/tables/ProjectRow.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@MichaelZhao21 MichaelZhao21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MichaelZhao21
Copy link
Contributor

Also this now resolves #158

@MichaelZhao21 MichaelZhao21 merged commit b3bafe0 into master Oct 22, 2024
2 checks passed
@MichaelZhao21 MichaelZhao21 deleted the admin/flags branch October 22, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants