Skip to content

Commit

Permalink
chore: remove GHC 9.6.2 spurious warning workarounds (#1162)
Browse files Browse the repository at this point in the history
  • Loading branch information
dhess committed Oct 9, 2023
2 parents 2498ca9 + b124dba commit a482844
Show file tree
Hide file tree
Showing 6 changed files with 0 additions and 24 deletions.
4 changes: 0 additions & 4 deletions primer-api/src/Primer/API.hs
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,6 @@
{-# LANGUAGE RecordWildCards #-}
{-# LANGUAGE TypeFamilies #-}

-- Temporary workaround for GHC 9.6:
-- https://gitlab.haskell.org/ghc/ghc/-/issues/23143
{-# OPTIONS -Wno-redundant-constraints #-}

-- | The Primer API.
--
-- This module defines the Primer API, which is collection of
Expand Down
4 changes: 0 additions & 4 deletions primer-api/test/Tests/Database.hs
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
{-# LANGUAGE GeneralizedNewtypeDeriving #-}

-- Temporary workaround for GHC 9.6:
-- https://gitlab.haskell.org/ghc/ghc/-/issues/23143
{-# OPTIONS -Wno-redundant-constraints #-}

module Tests.Database where

import Foreword
Expand Down
4 changes: 0 additions & 4 deletions primer-selda/src/Primer/Database/Selda/SQLite.hs
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
{-# LANGUAGE OverloadedLabels #-}
{-# LANGUAGE UndecidableInstances #-}

-- Temporary workaround for GHC 9.6:
-- https://gitlab.haskell.org/ghc/ghc/-/issues/23143
{-# OPTIONS -Wno-redundant-constraints #-}

module Primer.Database.Selda.SQLite (
-- * The "Database.Selda.SQLite" database adapter.
MonadSeldaSQLiteDb,
Expand Down
4 changes: 0 additions & 4 deletions primer/src/Primer/App.hs
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,6 @@
{-# LANGUAGE UndecidableInstances #-}
{-# LANGUAGE ViewPatterns #-}

-- Temporary workaround for GHC 9.6:
-- https://gitlab.haskell.org/ghc/ghc/-/issues/23143
{-# OPTIONS -Wno-redundant-constraints #-}

-- This module defines the high level application functions.

module Primer.App (
Expand Down
4 changes: 0 additions & 4 deletions primer/src/Primer/Database.hs
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
{-# LANGUAGE DuplicateRecordFields #-}
{-# LANGUAGE OverloadedLabels #-}

-- Temporary workaround for GHC 9.6:
-- https://gitlab.haskell.org/ghc/ghc/-/issues/23143
{-# OPTIONS -Wno-redundant-constraints #-}

module Primer.Database (
SessionId,
-- 'SessionName' is abstract. Do not export its constructors.
Expand Down
4 changes: 0 additions & 4 deletions primer/test/Tests/Database.hs
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
{-# LANGUAGE GeneralizedNewtypeDeriving #-}

-- Temporary workaround for GHC 9.6:
-- https://gitlab.haskell.org/ghc/ghc/-/issues/23143
{-# OPTIONS -Wno-redundant-constraints #-}

module Tests.Database where

import Foreword
Expand Down

1 comment on commit a482844

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Primer benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: a482844 Previous: 2498ca9 Ratio
evalTestM/pure logs/mapEven 1: outlier variance 0.15393873843082637 outlier variance 0.026296566837107228 outlier variance 5.85

This comment was automatically generated by workflow using github-action-benchmark.

CC: @dhess

Please sign in to comment.