refactor: move the Primer API into its own package #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Assuming there are no major objections to, or omissions in, this PR, could someone please add it to the merge queue once it's been reviewed and accepted? |
brprice
reviewed
Jul 4, 2023
brprice
reviewed
Jul 4, 2023
brprice
approved these changes
Jul 4, 2023
We would like to run evaluations in the browser, using GHC 9.6's support for Wasm and JavaScript targets. We won't need the API wrapper for that, nor type-checking, so this is the first step towards a more fine-grained set of packages in order to reduce the amount of code we need to compile for a Wasm/JavaScript target. This is a pure refactor. No tests or functionality have been removed, nor any new functionality or tests added. We've simply shuffled things around a bit, and moved some additional code into `primer-testlib` so that it can be reused in `primer-api`'s tests. Signed-off-by: Drew Hess <src@drewhess.com> Signed-off-by: Ben Price <ben@hackworthltd.com>
Signed-off-by: Ben Price <ben@hackworthltd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to run evaluations in the browser, using GHC 9.6's support for Wasm and JavaScript targets. We won't need the API wrapper for that, nor type-checking, so this is the first step towards a more fine-grained set of packages in order to reduce the amount of code we need to compile for a Wasm/JavaScript target.
This is a pure refactor. No tests or functionality have been removed, nor any new functionality or tests added. We've simply shuffled things around a bit, and moved some additional code into
primer-testlibso that it can be reused inprimer-api's tests.