Skip to content

Commit

Permalink
fix: Minor tsconfig.json fixes.
Browse files Browse the repository at this point in the history
Specifically:

* This file is used for typechecking the entire project (as opposed to
just the library portion, which is checked via a different tsconfig
file), and generates no type declarations, so set `noEmit` to
true (and remove command-line flag from script).

* Remove `outDir`, since nothing is emitted when using this config.

* Set `jsx` to "react-jsx" per recent versions of React.
  • Loading branch information
dhess committed Nov 27, 2022
1 parent 23433d0 commit 90e7a0d
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 6 deletions.
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
lib/
module/
node_modules/
coverage/
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"build": "npm run build:wasm && vite build && tsc --project ./tsconfig.type.json",
"doc": "typedoc src/index.ts",
"release": "npm run build && commit-and-tag-version",
"typecheck": "tsc --noEmit",
"typecheck": "tsc",
"storybook": "start-storybook -p 6006",
"build-storybook": "build-storybook",
"bench:wasm": "node --expose-gc test/benchmark.mjs"
Expand Down
7 changes: 3 additions & 4 deletions tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,11 @@
"resolveJsonModule": true,
"isolatedModules": true,
"strictNullChecks": true,
"noEmit": false,
"jsx": "preserve",
"noEmit": true,
"jsx": "react-jsx",
"downlevelIteration": true,
"rootDir": "./src",
"preserveSymlinks": true,
"outDir": "lib/"
"preserveSymlinks": true
},
"include": ["src"]
}

0 comments on commit 90e7a0d

Please sign in to comment.