bugfix #137 Fix template attributes forbidden (, masonen)

This PR was squashed before being merged into the master branch (closes #137).

Discussion
----------

This fixes #136 (and #106 )

The fix was pulled into development but never merged into master.

Commits
-------

c742978 - fix twigphp/Twig#2336, just need to import macros in all template

Resources/views/Ticket/show_attachment.html.twig

@@ -1,4 +1,5 @@
-{% import 'HackzillaTicketBundle:Macros:macros.html.twig' as macros %}
+{% import 'hackzilla_ticket.templates.macros' as macros %}
+
 {% if message.attachmentName %}
 <br>
 <div class="ticket_attachment">

TwigExtension/TicketFeatureExtension.php

@@ -3,10 +3,8 @@
 namespace Hackzilla\Bundle\TicketBundle\TwigExtension;
 
 use Hackzilla\Bundle\TicketBundle\Component\TicketFeatures;
-use Twig\Extension\AbstractExtension;
-use Twig\TwigFunction;
 
-class TicketFeatureExtension extends AbstractExtension
+class TicketFeatureExtension extends \Twig_Extension
 {
     private $ticketFeatures;
 
@@ -21,7 +19,7 @@ public function __construct(TicketFeatures $ticketFeatures)
     public function getFunctions()
     {
         return [
-            new TwigFunction('hasTicketFeature', [$this, 'hasFeature']),
+            new \Twig_SimpleFunction('hasTicketFeature', [$this, 'hasFeature']),
         ];
     }
 

TwigExtension/TicketGlobalExtension.php

@@ -2,10 +2,7 @@
 
 namespace Hackzilla\Bundle\TicketBundle\TwigExtension;
 
-use Twig\Extension\AbstractExtension;
-use Twig\Extension\GlobalsInterface;
-
-class TicketGlobalExtension extends AbstractExtension implements GlobalsInterface
+class TicketGlobalExtension extends \Twig_Extension implements \Twig_Extension_GlobalsInterface
 {
     protected $templates = [];
 

composer.json

@@ -28,7 +28,7 @@
         "php": "^5.6 || ^7.0",
         "doctrine/doctrine-bundle": "^1.4",
         "doctrine/orm": "^2.4.8",
-        "knplabs/knp-paginator-bundle": "^2.3 || ^3.0 || ^4.0",
+        "knplabs/knp-paginator-bundle": "^2.3 || ^3.0",
         "symfony/config": "^2.8 || ^3.0 || ^4.0",
         "symfony/console": "^2.8 || ^3.0 || ^4.0",
         "symfony/dependency-injection": "^2.8 || ^3.0 || ^4.0",
@@ -41,8 +41,7 @@
         "symfony/security-bundle": "^2.8 || ^3.0 || ^4.0",
         "symfony/translation": "^2.8 || ^3.0 || ^4.0",
         "symfony/validator": "^2.8 || ^3.0 || ^4.0",
-        "symfony/yaml": "^2.8 || ^3.0 || ^4.0",
-        "twig/twig": "^1.34 || ^2.0"
+        "symfony/yaml": "^2.8 || ^3.0 || ^4.0"
     },
     "require-dev": {
         "ext-pdo_sqlite": "*",
@@ -60,12 +59,6 @@
     "autoload": {
         "psr-4": {
             "Hackzilla\\Bundle\\TicketBundle\\": ""
-        },
-        "exclude-from-classmap": ["Tests/"]
-    },
-    "autoload-dev": {
-        "psr-4": {
-            "Hackzilla\\Bundle\\TicketBundle\\Tests\\": "Tests/"
         }
     },
     "config": {

phpunit.xml.dist

@@ -8,6 +8,7 @@
          convertWarningsToExceptions="true"
          processIsolation="false"
          stopOnFailure="false"
+         syntaxCheck="false"
          bootstrap="Tests/bootstrap.php"
 >
     <php>