-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump rustc version #655
Bump rustc version #655
Conversation
This will make it possible to reuse `Binder::hash()` instead of this manual hashing.
This doesn't change the hashes, only makes the hashing process easier to follow.
Cool, thanks, will review on Monday! |
With this PR we no longer call to_predicate before hashing Clauses |
Ah, I had no time to look at the code, that's great then! That's simplifies things |
There are a few other places where we take shortcuts with binders, we'll have to go through these too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 😀
Seems OK to me, one thing we should settle on is a vocabulary between clauses and predicates: those things now contain exactly the same pieces of information (if I understand correctly)
We should probably map both Predicate and Clause (from rustc) to Clause (from hax), wdyt?
Let's merge whenever you want @Nadrieril (do you have permissions to press merge though?) |
I don't have permissions to merge, you can go ahead |
Some interesting clause-related changes.
Regarding
Clause
hashing, I think we should either never hash the binder or prevent hashing without a binder; the current middle-ground is error-prone. Consistently ignoring the binder seems fine.