Refactor of clauses #662
Merged
Refactor of clauses #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nadrieril
reviewed
May 14, 2024
|
This is quite subtle because we need to make sure to either always hash the clause/predicate with its binder or never do that. Could you split this in a few commits that each do a single thing (e.g. 1. define |
|
Yes, I'm gonna rebase this nicely, no worries! After this PR, we should never compute a |
|
No problem, let me know when you have a version I can look at |
…`s and `Clause`s In commit [fca56a], the type `Clause` has been renamed as `ClauseKind`, then commit [21226e] makes `Clause` a `Binder<ClauseKind>`, essentially (with an indirection via `PredicateKind` and an invariant where the predicate kind has to be a `ty::PredicateKind::Clause(ClauseKind)`). That means that now, Rustc always provides `Clause` with binders. Thus, it now makes sense to systematically compute clause identifiers with binders. Since clauses are a subset of predicates, we now always lift clauses to predicates before computing identifiers. This was not possible before, since we lacked binder information to properly lift clauses to predicates [fca56a]: rust-lang/rust@fca56a8 [21226e]: rust-lang/rust@21226ee
Nadrieril
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the changes discussed in #661.
Fixes #661