Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(exporter): fixes #680 #681

Merged
merged 1 commit into from
May 22, 2024
Merged

fix(exporter): fixes #680 #681

merged 1 commit into from
May 22, 2024

Conversation

W95Psp
Copy link
Collaborator

@W95Psp W95Psp commented May 21, 2024

The translation of rustc_middle::mir::Place was assuming ConstantIndex was always operating on slices, but it can also operate on arrays.
This PR fixes that.

Fixes #680

Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@franziskuskiefer franziskuskiefer added this pull request to the merge queue May 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 22, 2024
@W95Psp W95Psp added this pull request to the merge queue May 22, 2024
Merged via the queue into main with commit a483aff May 22, 2024
13 checks passed
@W95Psp W95Psp deleted the fix-680 branch May 22, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Supposely unreachable place in the Rust AST. The label is "PlaceConstantIndexNotSlice".
2 participants