Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to OCaml 5 #694

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Update to OCaml 5 #694

merged 1 commit into from
Jun 12, 2024

Conversation

W95Psp
Copy link
Collaborator

@W95Psp W95Psp commented Jun 3, 2024

This PR updates the engine to OCaml 5

@W95Psp W95Psp marked this pull request as draft June 3, 2024 09:35
@W95Psp W95Psp force-pushed the update-ocaml-5 branch 2 times, most recently from 6b63650 to b03bab4 Compare June 6, 2024 12:39
@W95Psp W95Psp marked this pull request as ready for review June 6, 2024 12:40
@franziskuskiefer
Copy link
Member

Do we really want to do this when all our other tools don't? I'm of course all for updating, but I want to avoid incompatibilities.

@W95Psp
Copy link
Collaborator Author

W95Psp commented Jun 10, 2024

Mmh, I was not thinking about that indeed.
But the engine of hax is not used as an OCaml library from any other projects, and it doesn't consume any other projects as an OCaml library.
So, since the projects compose only at the binary level, I think there won't be any incompatibilities.
Does that make sense or I'm missing a source of incompatibility?

Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's try it and see what happens.

Where's that Rust change coming from? Looks like formatting?

@W95Psp
Copy link
Collaborator Author

W95Psp commented Jun 12, 2024

Yes, the Rust change is just about formatting. I think that's something rustfmt used not to format or something like that.

@W95Psp W95Psp added this pull request to the merge queue Jun 12, 2024
Merged via the queue into main with commit 6f3325e Jun 12, 2024
13 checks passed
@W95Psp W95Psp deleted the update-ocaml-5 branch June 12, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants