Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use strings to represent paths #722

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Don't use strings to represent paths #722

merged 1 commit into from
Jun 17, 2024

Conversation

Nadrieril
Copy link
Collaborator

No description provided.

W95Psp
W95Psp approved these changes Jun 17, 2024
View reviewed changes
Copy link
Collaborator

@W95Psp W95Psp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, definitely makes sense! I don't even recall why it's like that, but I see no good reason 🤔
Let's merge it!

@W95Psp W95Psp added this pull request to the merge queue Jun 17, 2024
Merged via the queue into hacspec:main with commit 6a3081c Jun 17, 2024
12 of 13 checks passed
@Nadrieril Nadrieril deleted the paths-arent-strings branch June 18, 2024 07:30
@Nadrieril Nadrieril mentioned this pull request Jun 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@W95Psp W95Psp W95Psp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
hax
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nadrieril @W95Psp