Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nix): reduce closure size for hax-engine #724

Merged
merged 2 commits into from
Jun 20, 2024
Merged

feat(nix): reduce closure size for hax-engine #724

merged 2 commits into from
Jun 20, 2024

Conversation

W95Psp
Copy link
Collaborator

@W95Psp W95Psp commented Jun 19, 2024 •
edited
Loading

This PR:

  • remove some rustc runtime dependencies in the nix build of hax-engine;
  • renames the nix derivation of the hax engine.

After this PR, nix bundle --bundler github:ralismark/nix-appimage ".#hax-engine.bin" produces a 21M self contained portable AppImage!

@W95Psp W95Psp added this pull request to the merge queue Jun 20, 2024
@W95Psp W95Psp mentioned this pull request Jun 20, 2024
Closed
Merged via the queue into main with commit d10f891 Jun 20, 2024
12 of 13 checks passed
@W95Psp W95Psp deleted the fix-hax-engine-nix-closure-size branch June 20, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franziskuskiefer franziskuskiefer franziskuskiefer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
hax
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@W95Psp @franziskuskiefer