Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rustc #733

Merged
4 commits merged into from
Jun 27, 2024
Merged

Update rustc #733

4 commits merged into from
Jun 27, 2024

Conversation

Nadrieril
Copy link
Collaborator

This updates rustc until Jan 1st 2024.

Comment on lines -113 to +120
let x:u32 = Core.Num.impl__u32__wrapping_add x 1ul in
let x:u32 = Core.Num.impl__u32__wrapping_add true x 1ul in
if x >. 3ul
then
let x:u32 = Core.Num.impl__u32__wrapping_sub x 3ul in
let x:u32 = Core.Num.impl__u32__wrapping_sub true x 3ul in
let y:u32 = x /! 2ul in
let y:u32 = Core.Num.impl__u32__wrapping_add y 2ul in
let y:u32 = Core.Num.impl__u32__wrapping_add true y 2ul in
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you can see examples of the new host parameter being added to some functions.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since they are removing that in a later nightly, wouldn't be it worth updating rustc to the latest nightly in once, so that we don't spend time working on something that will disappear later?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But in the same time, from rust-lang/rust#126552, it seems they want to re-introduce it at some point, so maybe we should suffer that pain now

Copy link
Collaborator Author

@Nadrieril Nadrieril Jun 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well they plan to add them back in a different form

Copy link
Collaborator Author

@Nadrieril Nadrieril Jun 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Essentially, if they're not too annoying I'd rather we shrug and let them be. If they're too annoying I can try moving 6 months at once but that'll be a lot of work.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, from that PR it looks like it affected only PartialEq and Add, which seems manageable.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To decide whether it's worth updating 6 months of rustc in once, the question is: what form will the new tracking of consts/effects will take? if it is still a const generic, the problem will be the same.

Also, another question is: can we, directly within the frontend, add an option to get rid of that host const generics both on method definitions and calls? I guess we should "just" lookup traits definition and check whether it was marked #[const_trait]? or it's more complicated?

@github-merge-queue github-merge-queue bot closed this pull request by merging all changes into hacspec:main in c711b19 Jun 27, 2024
@Nadrieril Nadrieril deleted the update-rustc2 branch June 28, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants