feat(exporter): thir: call: separate trait VS method generic args #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR separates method generic args and trait generic args of the
`call` nodes of THIR expressions.
Consider the following example:
```rust
trait MyTrait<TraitType> {
fn meth<MethType>(...) {...}
}
fn example_call<TraitType, SelfType: MyTrait<TraitType>>(x: SelfType) {
x.meth::<String>(...)
}
```
Before this commit, the call `x.meth::<String>` produced a `Call` node
whose field `generic_args` was `[SelfType, TraitType, String]`.
Now, that `Call` node has a trait-specific generic arguments field
`[SelfType, TraitType]` and a method/function-specific generic
arguments field `[String].`
This commit does no change to the engine, that will be for a
subsequent PR.
This PR is related to #719.
W95Psp
force-pushed
the
frontend-thir-calls-impl-generics
branch
from
c0ed2d2
to
14786e7
Compare
karthikbhargavan
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates method generic args and trait generic args of the
callnodes of THIR expressions.Consider the following example:
Before this commit, the call
x.meth::<String>produced aCallnode whose fieldgeneric_argswas[SelfType, TraitType, String].Now, that
Callnode has a trait-specific generic arguments field[SelfType, TraitType]and a method/function-specific generic arguments field[String].This commit does no change to the engine, that will be for a subsequent PR.
This PR is related to #719.