fix(frontend): kill crate_type in HaxMeta
#756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the field `crate_type` in the struct `HaxMeta`, and changes the path of `haxmeta` files. Originally, my intention was to name the `haxmeta` files very closely to `rmeta` files, but the `haxmeta` don't have anything to do with crate types. Also, the code was assuming a crate would have only one type, which is false, as the type suggests... That was making the frontend panic on certain crates.
franziskuskiefer
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the field
crate_typein the structHaxMeta, and changes the path ofhaxmetafiles.Originally, my intention was to name the
haxmetafiles very closely tormetafiles, but thehaxmetadon't have anything to do with crate types.Also, the code was assuming a crate would have only one type, which is false, as the type suggests... That was making the frontend panic on certain crates.