fix(hax-lib): refinements: various fixes #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
W95Psp
force-pushed
the
various-fixes-refinements
branch
from
a5195c6
to
c548cad
Compare
W95Psp
force-pushed
the
various-fixes-refinements
branch
from
c548cad
to
681d81b
Compare
W95Psp
force-pushed
the
various-fixes-refinements
branch
from
681d81b
to
3b5a15d
Compare
franziskuskiefer
approved these changes
Jul 10, 2024
Co-authored-by: Franziskus Kiefer <franziskuskiefer@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
f(y.get()).get()would rewritef(y.get()).get(), but not the innery.get(), and adds a test for thatunimplemented!