chore: remove duplicate phase #920
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit remove `phase_reconstruct_question_marks`, which is actually a stale copy of `phase_simplify_question_marks`...
W95Psp
force-pushed
the
remove-stale-dup-phase
branch
from
fb057a1 to
c675ff8
Compare
maximebuyse
approved these changes
Sep 30, 2024
|
Seems like the two phases are not doing exactly the same thing. I need to debug that. |
|
The PV backend uses one of those two phases, let's reassess that whenever we move to the #745 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes
phase_reconstruct_question_marks, which is actually a stale copy ofphase_simplify_question_marks...Work a bit toward #567